Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sys_usbd: Fix up sys_usbd_get_descriptor() error handling according to hardware test #14903

Merged
merged 1 commit into from
Dec 17, 2023

Conversation

brian218
Copy link
Contributor

@brian218 brian218 commented Dec 17, 2023

Today I carried out a hardware test for this syscall in response to @elad335's last comment in #14900 yesterday.
I tested the following conditions on my real hardware, and fixed up the error handling of this syscall accordingly:

  1. descriptor=NULL, desc_size=0x32 -> CELL_EINVAL
  2. descriptor=*ptr, desc_size=0 -> CELL_ENOMEM
  3. descriptor=NULL, desc_size=0 -> CELL_EINVAL

…o hardware test

usb_device_emulated: Allow partial copy of desscriptors
@elad335 elad335 merged commit 19d1e4d into RPCS3:master Dec 17, 2023
4 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants